search

eugenemel / maven

Maven GUI: Metabolomics Analysis and Visualization Engine
https://github.com/eugenemel/maven/releases
GNU General Public License v3.0
19 stars 10 forks source link

Release peakdetector CLI program as an artifact #737

Closed PMSeitzer closed 3 months ago

PMSeitzer commented 5 months ago

This will help support others running R scripts.

PMSeitzer commented 4 months ago

Consider including an R script (or R markdown file) in the maven repo to demonstrate how to use this feature.

PMSeitzer commented 4 months ago

Note previous related issue #540

PMSeitzer commented 4 months ago

Initial commit hash: 52b29a1ecf407e3c43139c5ed37bb2a2c61b23e3

PMSeitzer commented 4 months ago

As of 8f7a86825cb3f1bb66e9606d154db293082c5580, the peakdetector artifact is working for mac os, and is being created for windows, but the windows executable is not working.

Two options for this ticket: (1) Remove the peakdetector artifact from the windows build, and handle that in a separate issue. This would be the preferred course of option if external collaborators are using mac os x. (2) Get the windows peakdetector artifact working properly. This would be the preferred course of action if collaborators are using windows.

PMSeitzer commented 4 months ago

After consulting with collaborators, remove the windows build (for now), and focus on mac os x. windows work ported to new ticket: https://github.com/eugenemel/maven/issues/742

PMSeitzer commented 3 months ago

Port the analysis script described here: https://github.com/calico/mass_spec/issues/1380