search

eugenemel / maven

Maven GUI: Metabolomics Analysis and Visualization Engine
https://github.com/eugenemel/maven/releases
GNU General Public License v3.0
19 stars 9 forks source link

Export bug involving duplicate peakgroups #747

Closed PMSeitzer closed 1 day ago

PMSeitzer commented 2 months ago

Currently, if I have compound X identified 3 times and I mark one with a check and two with an X (or not at all), MAVEN exports the first in the list instead of preferentially exporting the check. To help clarify, if I mark them X, X, check, the csv will mark it as 'b'. However, if I mark them check, X, X, the csv reads 'g'. The same goes for no-label, so 'empty', 'empty', check, leads to it being marked 'empty'. I think it makes more sense if MAVEN exports the 'g' label if it is present for a compound, what do you think?

Progress109 commented 1 month ago
ExportIssue1 ExportIssue1 2
Progress109 commented 1 month ago
ExportIssue2 ExportIssue2 2
Progress109 commented 1 month ago
ExportIssue3 ExportIssue3 2
Progress109 commented 1 month ago
ExportIssue4 ExportIssue4 2
Progress109 commented 1 month ago
ExportIssue5 ExportIssue5 2
Progress109 commented 1 month ago

As you can see from the paired screenshots, when exported to a csv the top label is selected for exportation. I know that I can filter for certain labels and then export, but I think it could be useful if it could prioritise checks, so that I can get a complete list of all the compounds called and their labels.

PMSeitzer commented 1 day ago

Fixed as of 86f206cec23d900855758de38684a3861526f392