yskamoona
commented
10 years ago @eugenepan Hey Eugene,
:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. A few notes after checking out the code:
- Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
- You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
- Your project should include a Movie model that can deserialize from an NSDictionary.
- Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
- Nice work loading the images asynchronously.
- Nice work setting up the proper modes for the images so that they are not stretched. If you would to implement a full screen image on the DetailVC, you should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
- Nice work implementing the error message on network failure.
- Nice work on implementing some of the optionals.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
App complete. Please review. /cc @codepathreview