search

eugenesimakin / link-sharing-app

0 stars 0 forks source link

User profile picture implementation #14

Closed Washubrnfg85 closed 8 months ago

eugenesimakin commented 9 months ago

Checkstyle configuration added. Rebase to main.

Washubrnfg85 commented 9 months ago

Oh, crap!! Didn't mention your last commit. Will fix it tomorrow.

Washubrnfg85 commented 9 months ago

I don't know how to fix that check failure.

eugenesimakin commented 9 months ago

I don't know how to fix that check failure.

You can see the error here https://github.com/eugenesimakin/link-sharing-app/actions/runs/7314679783/job/19927550955?pr=14 or you can build the project locally using gradle and see the same error.

eugenesimakin commented 9 months ago

Looks like there is a bug in saving profile details (not profile picture). I added some tests so try to rebase to the main branch and run the tests. Or try to find the bug manually. Note: For running tests locally, remove "-headless" option.

Washubrnfg85 commented 8 months ago

You can see the error here https://github.com/eugenesimakin/link-sharing-app/actions/runs/7314679783/job/19927550955?pr=14 or you can build the project locally using gradle and see the same error.

Yeah, but I removed that line 93. And recommited it, but still...

eugenesimakin commented 8 months ago

Yeah, but I removed that line 93. And recommited it, but still...

The error message is [ERROR] /home/runner/work/link-sharing-app/link-sharing-app/src/main/java/org/linksharing/server/http/ApiRestController.java:93: Line is longer than 120 characters (found 138). [LineLength]

Here is the key part Line is longer than 120 characters (found 138).

PS. Do you want to get rid of checkstyle? It's not as good as I thought and not as good as linters for javascript in vscode.

Washubrnfg85 commented 8 months ago

Yeah, but I removed that line 93. And recommited it, but still...

The error message is [ERROR] /home/runner/work/link-sharing-app/link-sharing-app/src/main/java/org/linksharing/server/http/ApiRestController.java:93: Line is longer than 120 characters (found 138). [LineLength]

Here is the key part Line is longer than 120 characters (found 138).

I know. Tried to fix it. Maybe was tired.

PS. Do you want to get rid of checkstyle? It's not as good as I thought and not as good as linters for javascript in vscode.

Yes, please.

eugenesimakin commented 8 months ago

PS. Do you want to get rid of checkstyle? It's not as good as I thought and not as good as linters for javascript in vscode.

Yes, please.

Done. Rebase to main.

Washubrnfg85 commented 8 months ago

Please check out last commit. Something wrong with profile-details-page.html (script perhaps). Save button is disabled. Can't figure out why.