eugenevinitsky / sequential_social_dilemma_games

Repo for reproduction of sequential social dilemmas
MIT License
384 stars 134 forks source link

conv_to_fcnet accidentally embeds into smaller space #135

Closed eugenevinitsky closed 5 years ago

eugenevinitsky commented 5 years ago

The final line: output = slim.fully_connected( last_layer, num_outputs, weights_initializer=normc_initializer(0.01), activation_fn=None, scope="fc_out") embeds the inputs into num_outputs, but the last hidden_dim should actually go into the LSTM, not into this final hidden layer

eugenevinitsky commented 5 years ago

This is not actually true, the way rllib does things it actually ignores the final output layer before wrapping the LSTM