eugenevinitsky / sequential_social_dilemma_games

Repo for reproduction of sequential social dilemmas
MIT License
387 stars 132 forks source link

Hardcoded configuration values / configuration file #151

Open internetcoffeephone opened 5 years ago

internetcoffeephone commented 5 years ago

Currently, experiment configuration is hardcoded in (and duplicated across) training scripts. This is undesirable, as user-specific parameters can end up in them like so, which will generate errors when run by others.

It would be useful to separate these. I propose a .ini file plus a module that pushes the necessary configuration flags into tf.app.flags.FLAGS.

eugenevinitsky commented 5 years ago

Hey, I think this is great! If you'd like to add this, we would love it.