search

eugenevinitsky / sequential_social_dilemma_games

Repo for reproduction of sequential social dilemmas
MIT License
380 stars 134 forks source link

Feature request: update PettingZoo version #209

Open elliottower opened 1 year ago

elliottower commented 1 year ago

Hi, would it be possible to update this repo to use the most recent version of PettingZoo? We want to list this project in PettingZoo's third-party-environments, but we can only include environments which work with the current version.

If you need any help working out issues due to different versions feel free to ask, there were some breaking changes in version 1.2, so it requires a bit of code changes to adapt. The previous API returned done in the step() function, whereas the new one returns truncated and terminated (matching gymnasium). There is a migration guide for gymnasium explaining the changes further, the steps should be basically the same (we're working on making resources for updating old PettingZoo repositories as well): https://gymnasium.farama.org/content/migration-guide/

This issue https://github.com/eugenevinitsky/sequential_social_dilemma_games/issues/204 mentioned the breaking changes previously (involving dones), but hopefully I can provide a little more information and help with updating.

eugenevinitsky commented 1 year ago

Hey Elliott, I have no issue with that but I have 0 coding time these months and am unable to make these changes. If someone wants to open a PR doing it and ping me, I'll approve it.

eugenevinitsky commented 1 year ago

Sorry for the delay, bad maintainer behavior here.

elliottower commented 1 year ago

No worries, unfortunately I’m in the dan same boat here but maybe I’m the future. Cheers.

On Tue, May 9, 2023 at 4:18 AM Eugene Vinitsky @.***> wrote:

Hey Elliott, I have no issue with that but I have 0 coding time these months and am unable to make these changes. If someone wants to open a PR doing it and ping me, I'll approve it.

— Reply to this email directly, view it on GitHub https://github.com/eugenevinitsky/sequential_social_dilemma_games/issues/209#issuecomment-1539144397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVPVAY4BKTDBA2UVLJ4V53XFH4TZANCNFSM6AAAAAAWK5DYHM . You are receiving this because you authored the thread.Message ID: <eugenevinitsky/sequential_social_dilemma_games/issues/209/1539144397@ github.com>