search

eugeneware / debowerify

A browserify transform to enable the easy use of bower components in browserify client javascript projects. This can be used in conjunction with deamdify to require AMD components from bower as well.
491 stars 51 forks source link

Make debowerify work with more than 2 entries #67

Closed microadam closed 9 years ago

microadam commented 9 years ago

Apologies! Oversight from last PR!

eugeneware commented 9 years ago

I'm seeing a failed test. I think c.js needs to be added?

 Σ debowerify master$ npm test

> debowerify@1.3.1 test /Users/eugeneware/Dropbox/work/debowerify
> mocha

  ․

  0 passing (687ms)
  1 failing

  1) debowerify should be able to debowerify a module with multiple main entries:
     Error: module "./../bower_components/test-package-c/c.js" not found from "/Users/eugeneware/Dropbox/work/debowerify/public/multiple_main_entries.js"
      at notFound (/Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/index.js:744:15)
      at /Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/index.js:695:23
      at /Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/node_modules/browser-resolve/index.js:185:24
      at /Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/node_modules/resolve/lib/async.js:36:22
      at load (/Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/node_modules/resolve/lib/async.js:54:43)
      at /Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/node_modules/resolve/lib/async.js:60:22
      at /Users/eugeneware/Dropbox/work/debowerify/node_modules/browserify/node_modules/resolve/lib/async.js:16:47
      at Object.oncomplete (fs.js:107:15)
microadam commented 9 years ago

All commited! Missed those, doing things in a rush always ends up causing issues! Should all be good now

bobthecow commented 9 years ago

@maxnordlund There was an unresolved concern above. I'm pretty sure this will start overwriting code once it runs out of emptied out chunks.

maxnordlund commented 9 years ago

Darn it, I totally missed that one. I'm so sorry @bobthecow. Should we revert, or just not bump the version number yet?

bobthecow commented 9 years ago

Depends on how fast we can get a fix in :)

mkoryak commented 9 years ago

oh, this isnt fixed. i see.