search

eugeneware / docker-wordpress-nginx

A Dockerfile that installs the latest wordpress, nginx and php-fpm.
MIT License
874 stars 380 forks source link

Fix to tar clobbering /usr/share/nginx #15

Closed adonm closed 10 years ago

adonm commented 10 years ago

Latest version of docker doesn't extract remote tar files, so have to download then extract

adonm commented 10 years ago

Docker version 0.8.1, build a1598d1 for reference

eugeneware commented 10 years ago

Hi @adonm Thanks for the PR. Really annoying how docker keeps changing it's tar behavior!

I've taken the Dockfile changes, but have decided not to take the helper file as it's a bit too specific in mapping the volumes to /tmp/wordpress by default.

If people are using this image in a coreos or place where there may be multiple instances running at once this could cause conflicts.

adonm commented 10 years ago

Thanks Eugene, no probs

On 27 February 2014 16:04, Eugene Ware notifications@github.com wrote:

Hi @adonm https://github.com/adonm Thanks for the PR. Really annoying how docker keeps changing it's tar behavior!

I've taken the Dockfile changes, but have decided not to take the helper file as it's a bit too specific in mapping the volumes to /tmp/wordpressby default.

If people are using this image in a coreos or place where there may be multiple instances running at once this could cause conflicts.

— Reply to this email directly or view it on GitHubhttps://github.com/eugeneware/docker-wordpress-nginx/pull/15#issuecomment-36219106 .

Regards,

Adon Metcalfe