search

eugeneware / docker-wordpress-nginx

A Dockerfile that installs the latest wordpress, nginx and php-fpm.
MIT License
874 stars 380 forks source link

You should lock down the version of FROM=ubuntu #22

Closed AsavarTzeth closed 9 years ago

AsavarTzeth commented 10 years ago

I have noticed that because you have not specified the version of the ubuntu base image you use, docker pulls all versions available. This takes more time than necessary and makes a mess in your image repository.

If I understand things correctly you have now moved to 14.04 (nice!). Thus you should change "FROM=ubuntu" to "FROM=ubuntu:14.04".

Yes I know I can change this myself before building, but since other versions than the intended one often fail to build there is no point in not locking it to your recommended version.

Thanks in advance, and thanks for the recent quick fix.

eugeneware commented 10 years ago

Excellent point. I've fixed this and pushed this to master.

valentt commented 9 years ago

If this issue is fixed please close this issue.

AsavarTzeth commented 9 years ago

I had completely forgotten about this. Thank you for reminding me!