search

eugeneware / docker-wordpress-nginx

A Dockerfile that installs the latest wordpress, nginx and php-fpm.
MIT License
874 stars 380 forks source link

Update Dockerfile #26

Closed vegasbrianc closed 9 years ago

vegasbrianc commented 10 years ago

Changed the Wordpress installation to grab Wordpress from GitHub

eugeneware commented 10 years ago

Hi @vegasbrianc - I'm not sure that we should pull the latest svn head. Using the latest.tar.gz file will get us the latest stable official release. From the description on their git page they say:

WordPress, Git-ified. Synced via SVN every 15 minutes, including branches and tags!

I'm not sure that's what we want for stability. Thoughts? Unless master is always the stable release. Is there a release branch?

What's the advantage of git over pulling the latest release zip?

vegasbrianc commented 10 years ago

Hi @eugeneware I see what you mean. I just noticed a lot of other projects are pulling right from github. Seems both ways will work and will be stable as they are yncd with SVN. Either way is good with me :)

ericandrewlewis commented 9 years ago

Unless master is always the stable release. Is there a release branch?

No. Releases are tagged, but there is no release branch.

What's the advantage of git over pulling the latest release zip?

If you want WordPress in a git repository version :smile: e.g. You are a WordPress core contributor and would like to make patches etc.

This project doesn't seem to have a clear purpose other than "WordPress in a docker instance." Folks who know what that is can easily modify the script according to their needs.

I'd suggest closing this issue as wontfix.

joelchen commented 9 years ago

Latest stable release preferred.