search

eugeneware / docker-wordpress-nginx

A Dockerfile that installs the latest wordpress, nginx and php-fpm.
MIT License
874 stars 380 forks source link

Easier install #30

Open totty90 opened 10 years ago

totty90 commented 10 years ago

Instead of 

$ git clone https://github.com/eugeneware/docker-wordpress-nginx.git
$ cd docker-wordpress-nginx
$ sudo docker build -t="docker-wordpress-nginx" .

Use

docker pull eugeneware/docker-wordpress-nginx.

Also the

$ sudo docker run -p 80:80 --name docker-wordpress-nginx -d docker-wordpress-nginx

should be changed to:

sudo docker run -p 81:80 -d eugeneware/docker-wordpress-nginx
valentt commented 9 years ago

I agree, README needs these updates

eugeneware commented 9 years ago

The 81:81 change is only necessary if you have something running on port 80.

If you're using boot2docker, then you have a separate network interface where nothing should be conflicting. But it depends on how you use it.

denisinla commented 9 years ago

Perhaps a mention if using boot2docker that the proper URL for your host machine would be the ENV IP that boot2docker tells you to export upon initial install.

gwhite-dayspring commented 9 years ago

totty90 is right, specifically about the last suggestion. 'eugeneware/' needs to be added before the image name at the end of the docker run command. docker-wordpress-nginx by itself wasn't able to find the image I had just pulled. Adding that specificity of eugeneware/ makes it so that docker doesn't try to find it elsewhere.

eugeneware commented 9 years ago

Thanks. I've updated the README to use the fully qualified name. Any PRs for clarification of usage are welcome.

Neurogami commented 9 years ago

A suggestion for the README: The current instructions say:

To spawn a new instance of wordpress on port 80.  The -p 80:80 maps the internal docker port 80 to the outside port 80 of the host machine.

Consider adding something that explains which of these is the internal port and which is the outside port.

People already running a Website off their own server probably will not have outside port 80 available and will need to use something else.

Perhaps use an example where the two port numbers are different, or point out that the first port number is the outside port.

The current phrasing ("The -p 80:80 maps the internal docker port 80 to the outside port 80 of the host machine") implies that the the first port is the internal port.

eugeneware commented 9 years ago

Hi @Neurogami. Happy to take any README improvements. Would you be able to have a crack at an improvement and do a PR?