search

eugeneware / ffmpeg-static

ffmpeg static binaries for Mac OSX and Linux and Windows
GNU General Public License v3.0
1.07k stars 175 forks source link

Add FFmpeg 5.0 #96

Closed wolf-yuan-6115 closed 2 years ago

wolf-yuan-6115 commented 2 years ago

FFmpeg 5.0 is released now, but ffmpeg-static doesn't update yet. These mirrors have FFmpeg 5.0:

These mirrors don't have FFmpeg 5.0:

Platforms already have FFmpeg 5.0 binaries:

Platforms don't have FFmpeg 5.0 binaries:

derhuerst commented 2 years ago

cc @sudo-nautilus @thefrank

derhuerst commented 2 years ago

What needs to be done from the ffmpeg-static side:

sudo-nautilus commented 2 years ago

I believe that there are ffmpeg builds from the 5.0 branch, in my repo hmm

wolf-yuan-6115 commented 2 years ago

I believe that there are ffmpeg builds from the 5.0 branch, in my repo hmm

Oof sorry, I didn't see that...

Thefrank commented 2 years ago

I am currently waiting on patches for FreeBSD to show up in ports :(

pending commit: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261302 (I will give the patch here a try when I get some free time later this week)

derhuerst commented 2 years ago

@Thefrank any news? 🙂

Thefrank commented 2 years ago

It still has not even made it to FreeBSD ports. At this point I don't think its fair holding up 99% of the user base. You can drop support for now and once ffmpeg 5 is working under FreeBSD and I can get a static build of it, I can open a pull request to readd support.

Sorry about all of the delays here!

wolf-yuan-6115 commented 2 years ago

It still has not even made it to FreeBSD ports. At this point I don't think its fair holding up 99% of the user base. You can drop support for now and once ffmpeg 5 is working under FreeBSD and I can get a static build of it, I can open a pull request to readd support.

Sorry about all of the delays here!

Maybe this is better, why don't release FFmpeg 5.0? When user is using FreeBSD, then download FFmpeg 4.4 instead.

tylers-username commented 2 years ago

As an added thought here, would you be open to an MR (or this may require a fork) that implements this logic:

This would allow users to lock in the specific versions of ffmpeg that they require.

derhuerst commented 2 years ago

@tylerssn That already is a feature of all common package managers, right? There is a not very detailed doc for Yarn and one for npm on this.

Or am I misunderstand you?

derhuerst commented 2 years ago

@wolf-yuan-6115 @Thefrank I'll remove FreeBSD in ffmpeg-static@5.0.0, and we'll hopefully add it back later. People who need a FreeBSD will have to use ffmpeg-static@^4 then.

derhuerst commented 2 years ago

Published as ffmpeg-static@5.0.0. 🎉 Thanks everyone!

tylers-username commented 2 years ago

@tylerssn That already is a feature of all common package managers, right? There is a not very detailed doc for Yarn and one for npm on this.

Of course 😺 . I was just proposing two options to go about it—use the normal semantic versioning, except the major number represents the FFmpeg version.

Or to use semantic versioning for the repository (yarn add ffmpeg-static@repo-sem-ver followed by .ffmpeg-5.0, resulting in: yarn add ffmpeg-static@repo-sem-ver.ffmpeg-5.0

Either way, thanks for the quick work on this!

derhuerst commented 2 years ago

Of course 😺 . I was just proposing two options to go about it—use the normal semantic versioning, except the major number represents the FFmpeg version.

How would I upgrade the required Node.js version then, which is a breaking change, if no major ffmpeg version has been published?

Or to use semantic versioning for the repository (yarn add ffmpeg-static@repo-sem-ver followed by .ffmpeg-5.0, resulting in: yarn add ffmpeg-static@repo-sem-ver.ffmpeg-5.0

But then all the built-in SemVer mechanisms don't work anymore (e.g. npm upgrade ffmpeg-static/yarn upgrade). An option might be to use dist tags for this.

tylers-username commented 2 years ago

Looking at the dist tag docs, I don't think those will do the trick either.

Going back to what you actually implemented, that may be the win since this repo is literally ffmpeg-static. yarn add ffmpeg-static@5.0 installs ffmpeg 5.0; @4.0 installs 4.0, etc.

Thanks much for the work on this.

derhuerst commented 1 month ago

5.1.6

ffmpeg

ffprobe