search

eugenii / jqueryrotate

Automatically exported from code.google.com/p/jqueryrotate
1 stars 0 forks source link

IE 7 bug... #91

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
line 32:
this._rootObj.Wilq32 = 
{
    PhotoEffect: this
};

should be:

img.Wilq32 = 
{
    PhotoEffect: this
};

Original issue reported on code.google.com by donc...@gmail.com on 29 Jan 2013 at 6:13

GoogleCodeExporter commented 9 years ago 
Indeed - a leftover from an older version of jQueryRotate. But _rootObject 
should point to an img so there should be no real difference in usage, or I am 
wrong?

Original comment by wil...@gmail.com on 29 Jan 2013 at 6:23

GoogleCodeExporter commented 9 years ago 
on IE 7 no
line 81: 
this._rootObj=document.createElement('span');
this._rootObj.style.display="inline-block";

Original comment by donc...@gmail.com on 29 Jan 2013 at 6:43

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Ok I've taken a look at code directly, and the way it is right now - well in 
fact there is a reason why its like this (I assume you talk about version 2). 
Can you explain what is not working in IE7 exactly? 

Img is reference to an image object that will be replaced with VML object so 
with your change you could not access object directly from element (thats what 
this reference is for), where in the way its in code right now you can simply 
get a newly created element using getElementById (or by class name). The only 
case where it will not work is when you store reference to your image before 
calling .rotate and want to use it somewhere later on - in this case I would 
advice to first call .rotate and store a reference for a returned object.

Original comment by wil...@gmail.com on 29 Jan 2013 at 6:52

GoogleCodeExporter commented 9 years ago 
I would really apprecieate a jsfiddle.net test case where I could see issue if 
possible.

Original comment by wil...@gmail.com on 29 Jan 2013 at 6:53

GoogleCodeExporter commented 9 years ago

Original comment by wil...@gmail.com on 30 Jun 2013 at 8:14