Fix to work with tornado 5

eugeniy / pytest-tornado

A py.test plugin providing fixtures and markers to simplify testing of asynchronous tornado applications.

Apache License 2.0

121 stars 34 forks source link

Fix to work with tornado 5 #30

Closed vidartf closed 6 years ago

vidartf commented 6 years ago

See http://www.tornadoweb.org/en/stable/releases/v5.0.0.html .

Fixes use of io_loop keyword argument.
Removes calls to initialized() and instance() as they are removed/deprecated.

vidartf commented 6 years ago

Also fixes CI now.

vidartf commented 6 years ago

Since this repo seems dead, I've released a package pytest-tornado5 on PyPI based on my fork (this PR is merged into master there). If at some point in the future this repo becomes active again, I would be more than happy to merge back any changes.

eugeniy commented 6 years ago

Thanks for the pull request. I moved on from python development, so been neglecting this. I'll work on transferring the repo and pypi package to the pytest-dev org.

apast commented 6 years ago

@eugeniy Great! Thanks for your merge & reply.

Do you need some help to publish it on pypi? Maybe it's time to improve the release to 0.5, refering to Tornado 5?

Thanks,

Andre Pastore

eugeniy commented 6 years ago

@apast Sure, I'll start with the issues you opened.

apast commented 6 years ago

It really great, Eugeniy!

Please, let me know how can I help on this.

Thanks for you effort!

Andre

On Sat, Apr 21, 2018, 15:22 Eugeniy Kalinin notifications@github.com wrote:

@apast https://github.com/apast Sure, I'll start with the issues you opened.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eugeniy/pytest-tornado/pull/30#issuecomment-383318170, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7Q4aJwjGvrI8GrQrC4m4pP71d-AIteks5tq3jXgaJpZM4Smie9 .