search

eugeniy / pytest-tornado

A py.test plugin providing fixtures and markers to simplify testing of asynchronous tornado applications.
Apache License 2.0
121 stars 34 forks source link

Fixes two deprecation warnings #38

Closed reinhrst closed 5 years ago

reinhrst commented 6 years ago

First fixes #23; copied from #24 but keeping old code intact for python < 3.3

Second fixes #37

Jamim commented 6 years ago

Hi @eugeniy, These issues are a bit annoying. Could you please review & merge this PR? Thank you!

m-burst commented 6 years ago

Hi @eugeniy, It would be really great if this was fixed. Could you possibly have a look at this? Thanks!

Jamim commented 5 years ago

Hey @eugeniy,

Since pytest 4.0.0 is already there #23 is causing errors in CI when pytest is not pinned. Could you please merge this fix?

Or you can just grant write permissions to me or someone else who wants to see this library fixed :smile:

matthew-piziak commented 5 years ago

@eugeniy Could you take a look at this PR please?

scopatz commented 5 years ago

If @eugeniy isn't going to maintain this anymore, it might be worth forking the project and calling it something slightly different, like "tornado-pytest" and running with it from there.

jruizaranguren commented 5 years ago

@scopatz , @matthew-piziak, @reinhrst, @Jamim, Go for a separate fork? Eugeny did not make any contribution to github since 2018 April.

scopatz commented 5 years ago

There's a fork up at https://github.com/vidartf/pytest-tornado

jruizaranguren commented 5 years ago

Yes, but, Is it available in pypi? A plan to mantain the fork?

scopatz commented 5 years ago

It is in PyPI and I believe that @vidartf does plan on maintaining it.

jruizaranguren commented 5 years ago

Ok, it has the friendly name of 5 :-) https://pypi.org/project/pytest-tornado5/

vidartf commented 5 years ago

I called it that since the initial release was just for adding support for tornado 5. In hindsight, this was probably not the best choice 😅

jruizaranguren commented 5 years ago

Thanks for your contribution, in any case.

vidartf commented 5 years ago

Merging this for attribution, but will make some small tweaks later (will reference back to this PR). Thanks!