eugeniy / pytest-tornado

A py.test plugin providing fixtures and markers to simplify testing of asynchronous tornado applications.
Apache License 2.0
121 stars 34 forks source link

Project maintenance #41

Closed vidartf closed 5 years ago

vidartf commented 6 years ago

@eugeniy As you mentioned in https://github.com/eugeniy/pytest-tornado/pull/30, you moved on from python development, and wanted to transition the maintenance of the project to the pytest-dev org. How is this proceeding? In the meantime, would you mind adding a few others as maintainers? I'd be happy to volunteer some time for reviewing PRs and doing releases.

betatim commented 5 years ago

I'd be happy to help out a bit too.

Jamim commented 5 years ago

Hey @eugeniy, We miss you! :cry:

scopatz commented 5 years ago

Are other folks interested in forking this in the event that @eugeniy doesn't add others as maintainers?

Jamim commented 5 years ago

@scopatz I believe so, and I'm one of those who are interested in forking.

betatim commented 5 years ago

I've switched to https://github.com/pytest-dev/pytest-asyncio which works well. I think contributing there instead of creating a fork would be a good idea.

vidartf commented 5 years ago

I already have a fork I've been updating and releasing: https://github.com/vidartf/pytest-tornado (pypi: https://pypi.org/project/pytest-tornado5/ ). I've only been adding critical fixes for working with newer versions of pytest and tornado. That is a bit of a quick-fix, so if someone has a proposal for a better way to maintain a fork, I'm all ears.

vidartf commented 5 years ago

@betatim What would a tornado fixture with pytest-asyncio look like? That sounds like a good example to have in the readme (or linked to a gist?). If it does all the things that are needed, that might be a better solution.

betatim commented 5 years ago

Most of my knowledge comes from looking at JupyterHub's setup and the oauthenticator package for JupyterHub.

scopatz commented 5 years ago

Thanks for putting up the fork @vidartf - that seems like the right thing to do

okin commented 5 years ago

I have very loose test dependencies in order to be able to easily pick up the latest version of test plugins in use. Unfortunately with pytest 4 out and commonly in use I find pytest-tornado breaking for me in a lot of places and would love to see some progress on getting this project back to being maintained! @vidartf If help maintaining is wanted feel free to message me.

Would it be an option to fork the project to the pytest-dev org and then use pep 541 to gain ownership of the project on PyPI? This unfortunately seems like the more hostile route but I can't see that we will have any progress here in the future.

vidartf commented 5 years ago

@okin I'm not a maintainer here, but of a fork. If you want to help out there, that would be appreciated.

Would it be an option to fork the project to the pytest-dev org and then use pep 541 to gain ownership of the project on PyPI? This unfortunately seems like the more hostile route but I can't see that we will have any progress here in the future.

I think that should not be considered until other attempts to reach the author (outside of github) has been made. I'll try to send the author an email.

eugeniy commented 5 years ago

Gave @vidartf owner access to pypi and collaborator to this repo.

vidartf commented 5 years ago

I merged some existing PRs into master, and have now opened #43 to update master further. Any feedback from those in this thread on that PR would be very welcome!