search

eugeniy / pytest-tornado

A py.test plugin providing fixtures and markers to simplify testing of asynchronous tornado applications.
Apache License 2.0
121 stars 34 forks source link

pytest4 changed how markers work. Updating plugin to play nice. #42

Closed sheyman closed 5 years ago

sheyman commented 5 years ago

This change resolves issues such as:

RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue

and

RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly

For details on the reason these need to be updated, see https://docs.pytest.org/en/latest/mark.html#updating-code

Also bumped the minor version number from 0.5.0 to 0.5.1 - if that's wrong then feel free to revert or let me know and I will remove it. Thanks!

mikegrima commented 5 years ago

Any word on getting this merged in?

Talkopel commented 5 years ago

+1

vidartf commented 5 years ago

Resolved conflicts with #38 by assuming pytest > 3 (will formalize in later PR). I'll link to this PR in that subsequent PR. Feel free to take further discussion there, or in a new issue (no release planned until people have had some time to comment).