Add support for tornado version 6

eugeniy / pytest-tornado

A py.test plugin providing fixtures and markers to simplify testing of asynchronous tornado applications.

Apache License 2.0

121 stars 34 forks source link

Add support for tornado version 6 #49

Closed vidartf closed 5 years ago

vidartf commented 5 years ago

Adds CI for tornado 6.
Replaces deprecated API calls.
The new gen.sleep was added in 4.1, so that is the new lower requirement for the tornado dependency.

vidartf commented 5 years ago

This will be merged after 0.6.0 is released, c.f. #45.

vidartf commented 5 years ago

I'll give the current master a little exercise on one of my projects, and if it works well, I'll push an 0.7 release with these changes.

okin commented 5 years ago

@vidartf I did the same for one of my projects and current master worked fine for me.

One thing I did however notice is that it seems to be a bit slower in comparison. Not sure if this is due to changes in tornado or in pytest-tornado.

vidartf commented 5 years ago

@okin Thanks for the feedback. I can't really see anything on the side of pytest-tornado that would make things slower, but I'll keep it in mind for the future.