eugenkiss / kotlinfx

UNMAINTAINED: A layer on top of JavaFX to make better use of Kotlin's features.
MIT License
52 stars 8 forks source link

Does not compile with new Kotlin #8

Closed mikehearn closed 9 years ago

mikehearn commented 9 years ago

e: /Users/mike/Source/kotlinfx/kotlinfx-core/src/main/kotlin/kotlinfx/builders/Layout.kt: (188, 8): Super trait 'K' requires subclasses to extend 'Pane'

The error seems reasonable - this line contains RegionK and Region does not subclass Pane.

eugenkiss commented 9 years ago

Thanks for this remark. I found out that it makes no sense to have RegionK because Region, as you said, does not subclass Pane and therefore does not allow to dynamically add/remove children (see "Base class for layout panes which need to expose the children list as public so that users of the subclass can freely add/remove children." from http://docs.oracle.com/javase/8/javafx/api/javafx/scene/layout/Pane.html). So I simply removed RegionK.