search

eugenpt / lite-xl-vibe

VI(m?) Bindings (with a hint of Emacs) for lite-xl.
MIT License
55 stars 7 forks source link

Adding license and auto-formating #19

Open folliehiyuki opened 2 years ago

folliehiyuki commented 2 years ago

I suggest adding a license file, and also maybe a .luacheckrc or stylua.toml file to keep the source code format consistent (I think you can have luacheck or stylua run in Github action on push). This will make it easier for potential future contributors to scan through the code base.

Thanks for this amazing plugin btw.

eugenpt commented 2 years ago

Thanks for the suggestions) frankly I’m pretty sure my coding style and architecture are way too bad for anyone to follow and contribute

folliehiyuki commented 2 years ago

I already gave a quick look and made custom changes for my own use. Besides empty lines with spaces and inconsistent indents in big lists, it's not as bad as you think :)

jtbx commented 1 year ago

I want to re-distribute a fork of this plugin but I'm not sure if I'm legally allowed to, because there isn't a license. Could you add a license please?

eugenpt commented 1 year ago

I want to re-distribute a fork of this plugin but I'm not sure if I'm legally allowed to, because there isn't a license. Could you add a license please?

Are you seriously think about that in regards to some minor plugin for some text editor? Wow, maybe I should take my work more seriously.. I mean, I never thought this would be helpful or even of interest to anyone

I added a license, no problem, you may re-distribute whatever derivatives of this code any way you like

I'll have to think about auto-formatting for a little bit longer though

jtbx commented 1 year ago

Thanks!