eulerto / pgquarrel

pgquarrel compares PostgreSQL database schemas (DDL)
BSD 3-Clause "New" or "Revised" License
389 stars 42 forks source link

Support correct R_PATH linking on MacOS #90

Closed arieroos closed 4 years ago

arieroos commented 4 years ago

I successfully installed pgquarrel on my mac, but when I tried to run it I got the macos version of issue #87. This PR will fix it for MacOS.

This PR will also fix the following warning on MacOS:

CMake Warning (dev):
  Policy CMP0042 is not set: MACOSX_RPATH is enabled by default.  Run "cmake
  --help-policy CMP0042" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  MACOSX_RPATH is not specified for the following targets:

   mini

This warning is for project developers.  Use -Wno-dev to suppress it.

For some reason the INSTALL_RPATH property doesn't just work on macos. So we have to set the CMAKE_MACOSX_RPATH property for rpaths to work.

This change was inspired by PR #88

seslattery commented 4 years ago

Just wanted to say thanks and confirm this fix worked for me