search

eumario / godot-manager

A Project, Version and Addons/Plugins manager for Godot Game Engine.
MIT License
332 stars 19 forks source link

Project Scanning Crash #10

Closed Jborhi closed 2 years ago

Jborhi commented 2 years ago

Describe the bug Upon scanning for projects, program crashes.

To Reproduce Steps to reproduce the behavior: 1.Launch program 2.Click "Scan Projects" 3.Program Crashes

and

1.Launch Program 2.Go to settings and click projects 3.Tick "Scan each time Godot Manager is Launched" 4.Close program 5.Upon relaunch, program immediately crashes

Expected behavior Project files are scanned into program

OS and Program Version

Additional context Project folder contains nested folders

eumario commented 2 years ago

Could you tell me what is in Settings > Projects > Directories to Scan list?

revonzev commented 2 years ago

The cause seems to be that the program trying to scan a folder that doesn't exist.

How I recreate the problem: Create a folder, edit/add the "Directories to scan" to that folder and erase the folder. The default path value is "Documents\Projects" which the user probably doesn't have.

My suggestion: A popup to select what folder to scan when the scan button is clicked if "Directories to scan" is empty and made "Directories to scan" empty as default.

Jborhi commented 2 years ago

The cause seems to be that the program trying to scan a folder that doesn't exist.

How I recreate the problem: Create a folder and edit the "Directories to scan" to that folder and erase the folder. The default path value is "Documents\Project" which the user probably doesn't have.

I second that idea as my directories to scan is the default "Documents\Projects" and no such directory exists for me.

eumario commented 2 years ago

I had a feeling that it may be because there is no such folder to scan. So I will fix that.