Fix Windows 11 crash - Globalize installation path in GodotInstaller.cs

[dogboydog]

Hi,

Thanks for making this, I am using it as part of my development workflow and it's very nice. The official release of Godot Manager works for me on Windows 10, but when trying on a Windows 11 machine I immediately hit #64. I downloaded the project and debugged the failure. It seems like for some reason the behavior for using a user:// path directly in ZipFile is different on Windows 11

After running this change locally, I was able to install versions on 11 without issues.

Hopefully this fixes #64 for others as well

[dogboydog]

@droc101 If you would like I can send you a build and you can see if it works for you too.

[eumario]

I apologize for not responding before this, the reason why I haven't accepted this pull request, is that major re-work has been underway in migrating Godot Manager from Godot 3.x to Godot 4.x, which uses the Dotnet Framework, meaning more things will be a lot more responsive. I've also been in re-work of the Tuxfamily scraper, and generalizing it as a singular scraper, instead of multiple site scraper. Hopefully soon, I will be releasing Godot Manager 0.3.0, which will be an effective full re-write of the code, and already has this issue solved in it.

Again, apologize for the late response to this PR.

[dogboydog]

No problem. Looking forward to trying the new version. Maybe people just had better try the new version when it's available to see if it fixes this issue

[fmakawa]

Is there an ETA for the rework since this bug makes the project unusable in Windows 11? I also use it in Linux but for Windows, I am using Hourglass which lacks the template functionality you have here.

[fmakawa]

allowing this pull request as a patch seems prudent to allow the project to be usable even as there is a Godot 4.+ update coming

[dogboydog]

@fmakawa If you're able, could you try to build my version and let me know if it fixes the issue for you on Windows 11?

Or I could zip up a build here, but not sure if you'd be comfortable running it

[fmakawa]

@fmakawa If you're able, could you try to build my version and let me know if it fixes the issue for you on Windows 11?

Or I could zip up a build here, but not sure if you'd be comfortable running it

I am totally okay with that

[dogboydog]

Seems like maybe there will be a new release with my change and the instDir existing change eumario just mentioned

[eumario]

It is currently in the pipeline, building v0.2.2.

[fmakawa]

I can confirm that the build is no longer crashing. One thing to note, the build crashes if you try to create a new project when there are no prior projects already imported. If you import a project and then try to create a new project it works just fine.

[eumario]

@fmakawa Could you look in your %APPDATA%\Godot-Manager\logs and find the log with the crash when you attempt to create a new Project with no projects imported, and post a new bug report here with it? Thanks.

[fmakawa]

done