search

euniversal / umei-api-specification

UMEI API specifications
Apache License 2.0
3 stars 0 forks source link

removed timestamp parameter #61

Closed pruN-SIDE closed 2 years ago

pruN-SIDE commented 2 years ago

Remove the timestamp parameter used to define the to and from periods (using one parameter to generate another one was generating errors for the api generation).

Note: this PR also contains the changes done by @cdmNSIDE for the flexibilityZones and has to be merged after her PR.

cdmNSIDE commented 2 years ago

Hello @pruN-SIDE :) Can you change the destination of this PR (use the branch with the flexibility zones instead of "main") ? It will be much easier for us to do the review. Thanks

narve commented 2 years ago

Yes, also suggest changing the destination so that the PR is easier to review.

pruN-SIDE commented 2 years ago

Done, I would mostly need your advice concerning which parameters (related to periods) that can be nullable or not (I have put false by default for the moment) and perhaps an idea of how to shorten the description with the ISO-8601 format, thank you

narve commented 2 years ago

I would suggest another approach. This way we have lots of duplications in the file.

As far as I can see, the problem was that the timeStamp-definition was put in the parameters section but it should have been in the schemas-section.

narve commented 2 years ago

Can you have a look at my PR and see if that solves the problem? Or otherwise detail the problems so we can find a better solution?

https://github.com/euniversal/umei-api-specification/pull/65

pruN-SIDE commented 2 years ago

Not needed since timeStamp was moved to Schemas