Added completion type to the Order object and API parameters

euniversal / umei-api-specification

UMEI API specifications

Apache License 2.0

3 stars 0 forks source link

Closed oojorgeoo89 closed 2 years ago

oojorgeoo89 commented 2 years ago

Added Completion Type to:

cdmNSIDE commented 2 years ago

I would also suggest to explain the different completion types in the "glossary.md" file, as we did for the status.

oojorgeoo89 commented 2 years ago

Added details to the glossary as requested

cdmNSIDE commented 2 years ago

Ok for the glossary, thanks :) Do you agree with the 2 other suggestions highlighted in the code ?

oojorgeoo89 commented 2 years ago

thanks! I can't see any code suggestions, where should I look for them?

cdmNSIDE commented 2 years ago

I will copy paste them here, it will be easier:

The. new query parameter "completionType" must also be added to the GET Orders endpoints (for the moment it has been only added to the GET Trades and GET PublicOrders endpoints)
This new "completionType" field must also be added to the Trade resource (for the moment it has only been added to the Order resource)

cdmNSIDE commented 2 years ago

Sorry I removed the approval of Arnaud by mistake. I approved the PR on my side. You can merge it :)

oojorgeoo89 commented 2 years ago

Thanks! :) It won't let me complete it unless I get two approvals though