Closed Zheaoli closed 5 months ago
@Officeyutong Hi, thanks for the comment, I can't quote your previous comment(would you mind to keep the discussion next time?)
After the discussion, I think it would be great keep only find_package(LLVM REQUIRED CONFIG)
here. The developer could use the LLVM_ROOT
or -DLLVM_ROOT
to configure it. I think it would be better than hard code.
Meanwhile, the PR have following thing to do:
WDYT?
@Officeyutong Hi, thanks for the comment, I can't quote your previous comment(would you mind to keep the discussion next time?)
After the discussion, I think it would be great keep only
find_package(LLVM REQUIRED CONFIG)
here. The developer could use theLLVM_ROOT
or-DLLVM_ROOT
to configure it. I think it would be better than hard code.Meanwhile, the PR have following thing to do:
- Forbid LLVM-14
- Make CI Happy
WDYT?
In fact I don't know which is better, may be you should consult @yunwei37
@Officeyutong Hi, thanks for the comment, I can't quote your previous comment(would you mind to keep the discussion next time?) After the discussion, I think it would be great keep only
find_package(LLVM REQUIRED CONFIG)
here. The developer could use theLLVM_ROOT
or-DLLVM_ROOT
to configure it. I think it would be better than hard code. Meanwhile, the PR have following thing to do:
- Forbid LLVM-14
- Make CI Happy
WDYT?
In fact I don't know which is better, may be you should consult @yunwei37
Note that the following workflows should be updated:
I think using find_package is ok.
Maybe we can update the bpftime build-and-test documents in eunomia.dev, to tell others the best way to compile it and set the cmake variables.
Thanks for your help!
And also, is it better to delete the makefile in project root? There are too many options for the makefile to handle, maintaining the makefile and cmake together will also make user confused. What do you think?
If it's better, we can update the ci and documents in
https://eunomia.dev/bpftime/documents/build-and-test/
It can also help with #173
I think it could be a split PR. I will simplify the build process and the doc
Yes. It should be another issue and pr. Thanks a lot!
Also fix #203
LGTM, Thanks!
Description
Fixes #187
In this PR, I make some changes following below:
LLVM_FIND_PATH
to let people customize the LLVM path themselfENABLE_LLVM_SHARED
for some special distributions which are make the LLVM all dynamic lib (like Arch Linux, FYI https://gitlab.archlinux.org/archlinux/packaging/packages/llvm/-/commit/3e452a15b68d156a9ef5608e8f6e1870d192d954)Type of change
How Has This Been Tested?
Test Configuration:
Checklist