yeonns commented 2 years ago

As the number of gtests increases, the build fails on API30 as it does with API28. On API30, the build fails after 285 tests.

limitation

API28: 227 tests
API30: 285 tests

yeonns commented 2 years ago

@euphony-io/all-ca-members I think we have to reduce gtest test cases. 😢 Or is there any other good way?

kuro11pow2 commented 2 years ago

I can't believe this problem happens in other versions. It was a more serious problem than I thought. 😢 I'll find another way.

kuro11pow2 commented 2 years ago

@yeonns I succeeded in building with API 30 in upsteam/master. There are 346 test cases. And it was also successful when API 24 and API 30 were tested at the same time. Is there any other information on this issue?

API 30

API 24 + API 30

yeonns commented 2 years ago

@kuro11pow2 Sorry for late response. There are two types of errors. I don't know why. 😢

Development Environment

Android Studio 4.2.2
Windows 10
Galaxy S20 FE (API30)
git pull euphony master

Build Log (Error Type1)

[7/7] Linking CXX executable C:\git\openup\euphony\euphony\build\intermediates\cmake\debug\obj\arm64-v8a\testEuphony
FAILED: C:/git/openup/euphony/euphony/build/intermediates/cmake/debug/obj/arm64-v8a/testEuphony 
cmd.exe /C "cd . && C:\Users\user\AppData\Local\Android\Sdk\ndk\21.4.7075529\toolchains\llvm\prebuilt\windows-x86_64\bin\clang++.exe --target=aarch64-none-linux-android21 --gcc-toolchain=C:/Users/user/AppData/Local/Android/Sdk/ndk/21.4.7075529/toolchains/llvm/prebuilt/windows-x86_64 --sysroot=C:/Users/user/AppData/Local/Android/Sdk/ndk/21.4.7075529/toolchains/llvm/prebuilt/windows-x86_64/sysroot  -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security  -std=c++14 -fopenmp -O0 -fno-limit-debug-info  -Wl,--exclude-libs,libgcc.a -Wl,--exclude-libs,libgcc_real.a -Wl,--exclude-libs,libatomic.a -Wl,--build-id -Wl,--fatal-warnings -Wl,--no-undefined -Qunused-arguments -Wl,--gc-sections tests/CMakeFiles/testEuphony.dir/asciiCharsetTest.cpp.o tests/CMakeFiles/testEuphony.dir/utf8CharsetTest.cpp.o tests/CMakeFiles/testEuphony.dir/utf16CharsetTest.cpp.o tests/CMakeFiles/testEuphony.dir/utf32CharsetTest.cpp.o tests/CMakeFiles/testEuphony.dir/base2Test.cpp.o tests/CMakeFiles/testEuphony.dir/base32Test.cpp.o tests/CMakeFiles/testEuphony.dir/base16Test.cpp.o tests/CMakeFiles/testEuphony.dir/base64Test.cpp.o tests/CMakeFiles/testEuphony.dir/defaultCharsetTest.cpp.o tests/CMakeFiles/testEuphony.dir/FFTTest.cpp.o tests/CMakeFiles/testEuphony.dir/FSKTest.cpp.o tests/CMakeFiles/testEuphony.dir/hexVectorTest.cpp.o tests/CMakeFiles/testEuphony.dir/packetTest.cpp.o tests/CMakeFiles/testEuphony.dir/packetBuilderTest.cpp.o tests/CMakeFiles/testEuphony.dir/packetErrorDetectorTest.cpp.o tests/CMakeFiles/testEuphony.dir/packetWithFSKTest.cpp.o tests/CMakeFiles/testEuphony.dir/waveTest.cpp.o tests/CMakeFiles/testEuphony.dir/waveBuilderTest.cpp.o tests/CMakeFiles/testEuphony.dir/waveRendererTest.cpp.o  -o C:\git\openup\euphony\euphony\build\intermediates\cmake\debug\obj\arm64-v8a\testEuphony  C:/git/openup/euphony/euphony/build/intermediates/cmake/debug/obj/arm64-v8a/libeuphony.so tests/libgtest.a -llog -lOpenSLES C:/Users/user/.gradle/caches/transforms-2/files-2.1/2fc06640f22f0b2c2519ff4c360c6065/oboe-1.6.1/prefab/modules/oboe/libs/android.arm64-v8a/liboboe.so -fopenmp -static-openmp -latomic -lm && cmd.exe /C "cd /D C:\git\openup\euphony\euphony\.cxx\cmake\debug\arm64-v8a\tests && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X shell mkdir -p /data/local/tmp/testEuphony/arm64-v8a && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X push C:/git/openup/euphony/euphony/build/intermediates/cmake/debug/obj/arm64-v8a/libeuphony.so /data/local/tmp/testEuphony/arm64-v8a/ && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X push C:/Users/user/.gradle/caches/transforms-2/files-2.1/2fc06640f22f0b2c2519ff4c360c6065/oboe-1.6.1/prefab/modules/oboe/libs/android.arm64-v8a/liboboe.so /data/local/tmp/testEuphony/arm64-v8a/ && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X push C:/Users/user/AppData/Local/Android/Sdk/ndk/21.4.7075529/sources/cxx-stl/llvm-libc++/libs/arm64-v8a/libc++_shared.so /data/local/tmp/testEuphony/arm64-v8a/ && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X push C:/git/openup/euphony/euphony/build/intermediates/cmake/debug/obj/arm64-v8a/testEuphony /data/local/tmp/testEuphony/arm64-v8a/ && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X shell chmod 755 /data/local/tmp/testEuphony/arm64-v8a/testEuphony && cd /D C:\git\openup\euphony\euphony\.cxx\cmake\debug\arm64-v8a\tests && C:\Users\user\AppData\Local\Android\Sdk\cmake\3.10.2.4988404\bin\cmake.exe -DADB:STRING="C:/Program Files/Android/platform-tools/adb.exe" -DSERIAL:STRING="R3CN90X4H9X" -DTARGET_TEST_LIB_DIR:STRING="/data/local/tmp/testEuphony/arm64-v8a" -P C:/git/openup/euphony/euphony/src/main/cpp/tests/cmake.run.test.script && cd /D C:\git\openup\euphony\euphony\.cxx\cmake\debug\arm64-v8a\tests && "C:\Program Files\Android\platform-tools\adb.exe" -s R3CN90X4H9X shell rm -r /data/local/tmp/testEuphony/arm64-v8a""
C:/git/openup/euphony/euphony/build/intermediates/cmake/debug/obj/arm64-v8a/libeuphony.so: 1 file pushed, 0 skipped. 82.7 MB/s (2831824 bytes in 0.033s)
C:/Users/user/.gradle/caches/transforms-2/files-2.1/2fc06640f22f0b2c2519ff4c360c6065/oboe-1.6.1/prefab/modules/oboe/libs/android.arm64-v8a/liboboe.so: 1 file pushed, 0 skipped. 124.6 MB/s (2772568 bytes in 0.021s)
C:/Users/user/AppData/Local/Android/Sdk/ndk/21.4.7075529/sources/cxx-stl/llvm-libc++/libs/arm64-v8a/libc++_shared.so: 1 file pushed, 0 skipped. 92.0 MB/s (6235072 bytes in 0.065s)
C:/git/openup/euphony/euphony/build/intermediates/cmake/debug/obj/arm64-v8a/testEuphony: 1 file pushed, 0 skipped. 155.3 MB/s (14960624 bytes in 0.092s)
CMake Error at C:/git/openup/euphony/euphony/src/main/cpp/tests/cmake.run.test.script:12 (message):
  ** Gtest Failure (139) **
Running main() from
  C:/Users/user/AppData/Local/Android/Sdk/ndk/21.4.7075529/sources/third_party/googletest/src/gtest_main.cc
[==========]
  Running 346 tests from 23 test suites.

Build Log(Error Type2)

Build Success Environment

Modify utf32CharsetTest.cpp (Removed almost all tests)

INSTANTIATE_TEST_CASE_P(
    ChrasetDecodingTestSuite,
    UTF32CharsetTestFixture,
    ::testing::Values(
            TestParamType("a", "00000061")
    ));

Modify utf16CharsetTest.cpp (Removed almost all tests)

INSTANTIATE_TEST_CASE_P(
    ChrasetDecodingTestSuite,
    UTF16CharsetTestFixture,
    ::testing::Values(
            TestParamType("가", "ac00"),
            TestParamType("36.5℃", "00330036002e00352103")
    ));

designe commented 2 years ago

Let me test those cases!! Thanks for sharing the unit-test issues!

designe commented 2 years ago

@yeonns I made 500 test cases at API 30. but there are no issues.

I'm going to check S20 FE device with same environment!

euphony-io / euphony

can't run gtest after #106 #116

limitation

API 30

API 24 + API 30

Development Environment

Build Log (Error Type1)

Build Log(Error Type2)

Build Success Environment