euphoria-io / heim

A real-time community platform.
https://euphoria.io
Other
872 stars 47 forks source link

Fix #42. #57

Closed ArkaneMoose closed 8 years ago

ArkaneMoose commented 8 years ago

As I've described in my comment in #42, I believe that IE's implementation of window.getSelection() does not count a selection in a text input field as a range.

Therefore, I believe that this PR should fix #42 by checking if selection.rangeCount is 0 before calling selection.getRangeAt(0).

chromakode commented 8 years ago

Thanks much for digging on this! I will try to replicate your findings in IE soon & give an update.

logan commented 8 years ago

Merged, thanks!