euphoria-io / heim

A real-time community platform.
https://euphoria.io
Other
874 stars 47 forks source link

Character Limit on Posts limits bots #81

Closed Baconchicken42 closed 7 years ago

Baconchicken42 commented 8 years ago

as of March 22, 2016 I was working on a new addition to @EmoBot. If you're ever in &xkcd you'll probably know what it is. Anyways, the code for it is super long. So the character limit blocks out most of it, even though the code is still there and @BotBot can still read it and create the bot. However, today I found that one of the new things I added wasn't working. I added a !test command at the end of the code, and that didn't work either. Is there another character limit that stops the post entirely, is this a botbot issue, or something else entirely? Any help would be appreciated.

CylonicRaider commented 7 years ago

Messages are truncated to 4096 characters except when submitting one or using the get-message command; those are limited to 1MiB of UTF-8. @BotBot was specifically patched to support long messages (https://github.com/ArkaneMoose/BotBot/pull/27)... but all that was way after this issue, so it is probably obsolete.

Baconchicken42 commented 7 years ago

Why am I getting this email now, and not at any of the myriad other times i put in botbot code that got truncated?

On Mon, Apr 24, 2017 at 1:39 PM, CylonicRaider notifications@github.com wrote:

Messages are truncated to 4096 characters except when submitting one or using the get-message command; those are limited to 1MiB of UTF-8. @BotBot https://github.com/BotBot was specifically patched to support long messages (ArkaneMoose/BotBot#27 https://github.com/ArkaneMoose/BotBot/pull/27)... but all that was way after this issue, so it is probably obsolete.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/euphoria-io/heim/issues/81#issuecomment-296763570, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLxvEU9AscBuqexRGJAwvWa0sMm92o3ks5rzN42gaJpZM4H2rFG .

CylonicRaider commented 7 years ago

To quote myself, [Xyzzy] /me is meanwhile going through the Euphoria issues and commenting on them

Baconchicken42 commented 7 years ago

Ok then

On Mon, Apr 24, 2017 at 1:45 PM, CylonicRaider notifications@github.com wrote:

To quote myself, [Xyzzy] /me is meanwhile going through the Euphoria issues and commenting on them

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/euphoria-io/heim/issues/81#issuecomment-296765950, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLxvCx7e7MJONMMhxWKdd0n9WUQe-noks5rzN-cgaJpZM4H2rFG .

ArkaneMoose commented 7 years ago

To my knowledge, any code shorter than one 1 MiB should be accepted by BotBot because BotBot uses Euphoria's get-message API to retrieve the non-truncated version of the message. (This has been implemented since ArkaneMoose/BotBot@7d1ec15.) However, the code may still appear to be truncated in the Euphoria interface. (I tested this in &bots just now, and it appears to be working; code that was truncated was correctly handled.)

CylonicRaider commented 7 years ago

To my knowledge, any code shorter than one 1 MiB should be accepted by BotBot because BotBot uses Euphoria's get-message API to retrieve the non-truncated version of the message. (This has been implemented since ArkaneMoose/BotBot@7d1ec15.)

...Just as I pointed out above. :smile:

@BotBot was specifically patched to support long messages (ArkaneMoose/BotBot#27)...

Aside from all that, I vote to close this issue.

ArkaneMoose commented 7 years ago

Yep, sorry. I also vote to close.

kaliumxyz commented 7 years ago

Xyzzers pl0x close.

CylonicRaider commented 7 years ago

...I fear that is beyond my power... @logan pl0x?

Baconchicken42 commented 7 years ago

while i'm in this email thread, I vote to close as well, I guess?

On Mon, Apr 24, 2017 at 4:05 PM, CylonicRaider notifications@github.com wrote:

...I fear that is beyond my power... @logan https://github.com/logan pl0x?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/euphoria-io/heim/issues/81#issuecomment-296807009, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLxvGZOfSCAZcAtOXZMVmJuyRmrrvhnks5rzQCjgaJpZM4H2rFG .

CylonicRaider commented 7 years ago

Actually, you might be able to close it as well, @Baconchicken42.

Baconchicken42 commented 7 years ago

What do you mean?

On Mon, Apr 24, 2017 at 4:22 PM, CylonicRaider notifications@github.com wrote:

Actually, you might be able to close it as well, @Baconchicken42 https://github.com/Baconchicken42.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/euphoria-io/heim/issues/81#issuecomment-296810967, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLxvHdhCzpCn3GjSx5_t6E3Uw-FVD4xks5rzQR2gaJpZM4H2rFG .

totallyhuman commented 7 years ago

Hot? Hot? I want to be here!

kaliumxyz commented 7 years ago

You can close your own issues.

totallyhuman commented 7 years ago

You gotta get to the website though. You can't do it via email.

kaliumxyz commented 7 years ago

unlike in real life.

CylonicRaider commented 7 years ago

@Baconchicken42, if you care to log in to GitHub, you should be able to close the issue from the button in the comment box.

Baconchicken42 commented 7 years ago

You know, I forgot entirely that I even opened this. Funnily enough the problem was that I forgot a parenthese and I fixed it a while ago.

totallyhuman commented 7 years ago

Hooray! We did it, &xkcd!

CylonicRaider commented 7 years ago

Quick poll, should Euphoria have embedded emoji replies? :laughing:

mechanical-girl commented 7 years ago

Yay us!

Baconchicken42 commented 7 years ago

Yay!

On Mon, Apr 24, 2017 at 4:32 PM, Struan Duncan-Wilson < notifications@github.com> wrote:

Yay us!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/euphoria-io/heim/issues/81#issuecomment-296813484, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLxvB2YD13dmP_I6frc-QQfHUwipTypks5rzQbVgaJpZM4H2rFG .

CylonicRaider commented 7 years ago

Quick poll, should Euphoria have embedded emoji replies? :laughing:

In addition, should those accumulate into “karma” points displayed on a user's profile?

totallyhuman commented 7 years ago

You'd have to implement profile pages as well, though.

CylonicRaider commented 7 years ago

You'd have to implement profile pages as well, though.

Killjoy! :-1:

totallyhuman commented 7 years ago

😛

EDIT: By all means, if you can, do it. I'm not one to discourage a cool feature based on the amount of work somebody else has to put into it.

kaliumxyz commented 7 years ago

Just give everyone a score, I encourage said score to be based on.... some post count and emoji usage metric.

totallyhuman commented 7 years ago

Or slang memes usage.

CylonicRaider commented 7 years ago

This thread keeps giving and giving. :laughing:

totallyhuman commented 7 years ago

Wait a minute... can you call this a thread?

CylonicRaider commented 7 years ago

Yes, this is an oldschool forum thread.

totallyhuman commented 7 years ago

In that case, threading was boring.