search

euphorie / Euphorie

Euphorie is a tool for risk assessment
https://pythonhosted.org/Euphorie/
GNU General Public License v2.0
11 stars 6 forks source link

Use weasyprint for PDF generation #683

Closed reinhardt closed 5 months ago

reinhardt commented 6 months ago

syslabcom/scrum#732

reinhardt commented 6 months ago

Is this OK to merge or do you want the log level hack from quaive/ploneintranet#5319 here as well?

ale-rt commented 6 months ago

I was not yet able to try this branch,

The goal for me is to check that we have a solution that produces a PDF with a quality comparable with the one wkhtmltopdf was producing and that has no side effects. I would not like to review this PR again and come back to you asking changes because the PDF differs too much from the previous implementation or because we are flooded by log lines.

So please, check that the PR is in a mergeable state before I invest time in reviewing it.

Thank you.

reinhardt commented 6 months ago

produces a PDF with a quality comparable with the one wkhtmltopdf was producing and that has no side effects

I'm not aware that this is part of a code review. It sounds like you want to do QA already.

ale-rt commented 5 months ago

I tested this and the problem of the excessive logging still exists. In addition, the two produced PDFs look quite a lot different. image Left is wkhtmltopdf, right is weasyprint.

I would say it would be ok if they are not identical but IMO the font size is too big for the new report. This also has the consequence of having the date split on two lines: image

Can you please recheck?