search

eupn / macrotest

Test harness for declarative and procedural macros expansion via `cargo-expand`
47 stars 9 forks source link

Add: test-virtual (related issue #71) #72

Open taqtiqa-mark opened 2 years ago

taqtiqa-mark commented 2 years ago

This initial commit contains the state of play immediately after add the example crates:

Other than setting up the workspace references no changes to the example crates have been made.

The integration test harness has not yet been implemented.

Signed-off-by: Mark Van de Vyver mark@taqtiqa.com

taqtiqa-mark commented 5 months ago

Just to clarify the state of play here. Previously this was motivated by:

a infinyon/fluvio plugin-style integration test harness

However, with some experience, that seemed an overly complicated approach (check out the current state of the fluvio integration test code...).

Currently, one can get a generic and elegant template using DJB's redo build system, and following a couple of conventions.

taiki-e commented 4 months ago

All related issues have been closed, but is there still a problem with your use case?

taqtiqa-mark commented 4 months ago

Setting up a integration test env for a virtual workspace, using the hierarchy of crates that proc-macros necessitate, is a non trivial exercise. So I think there is some value adding this template to the two existing templates is worth while.

As you have observed first hand, it exposed one bug, and its presence should guard against regressions and other issues.

Understand if you disagree and wish to close this as out of scope.

Otherwise, I'll ping you when I believe it is ready for review?