eupn / macrotest

Test harness for declarative and procedural macros expansion via `cargo-expand`
47 stars 9 forks source link

git tag missing for 1.0.9 #97

Open ijackson opened 5 months ago

ijackson commented 5 months ago

I wanted to investigate an issue, but found that I although was using 1.0.9 from crates.io but there wasn't a corresponding git tag.

Normally, cargo puts a .cargo_vcs_info.json in the generated .crate file, if the release is made from git. Investigating the .crate file I think the release was made roughly from 3751785. The only difference (apart from changes made to Cargo.toml by cargo publish) is a one-line change to .gitignore.

Was 1.0.9 made from a dirty git working tree? I recommend the use of automated tooling for releasing which checks things like "is the git tree clean" and also makes the tags.

To remedy this, I suggest: make a temporary git branch containing this delta

diff --git a/.gitignore b/.gitignore
index ff23b2d..9345978 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,4 @@ Cargo.lock
 *.iml
 *.ipr
 *.iws
+.idea

and tag it 1.0.9