eupn / stm32wb-hal

[WIP] embedded-hal for the STM32WB family of microcontrollers
20 stars 10 forks source link

RFC: Switch pac to upstream stm32-rs #18

Open karlp opened 3 years ago

karlp commented 3 years ago

This is built on my other patch series, and switches to "upstream" stm32-rs pac.

The real change here is all in https://github.com/eupn/stm32wb-hal/commit/c1e3a1c37fac8a86cf772d5347e19a656281198c

It depends on either https://github.com/stm32-rs/stm32-rs/pull/624 or https://github.com/stm32-rs/stm32-rs/pull/473 so it's only an RFC at the moment. When/If those merge/release, the deps can be properly updated to a real version, instead of me having a local crate source override.

I've tested this with downstream examples from the eupn/stm32wb55 repo (BTLE ibeacon was a quick one) and also some other downstream apps using this hal.

I know this effectively obsoletes a chunk of your own work, and I'm not trying to step on your toes or anything, but it seems like the PAC layer at least could come from the stm32-rs project and get us a lot of work done for free.