search

eurec4a / eurec4a-intake

Intake catalogue for EUREC4A field campaign datasets
17 stars 19 forks source link

Remove item.discover from test #102

Closed observingClouds closed 1 year ago

observingClouds commented 2 years ago

Is this line necessary? https://github.com/eurec4a/eurec4a-intake/blob/6bbfab8a59af878d7e8aedde9a4ce859da9dcedd/tests/test_catalog.py#L43

There is an issue with the discover method for JSON-typed catalog entries like proposed in #99 (see failing test). The discover-method is currently not implemented, but I proposed a solution at https://github.com/intake/intake/issues/673

However, I do not see why we necessarily have to call item.discover anyway. Can we drop it or at least use an alternative?

Cheers!

observingClouds commented 2 years ago

cc @leifdenby

d70-t commented 2 years ago

Maybe it's indeed not necessary...

observingClouds commented 1 year ago

This is what I thought as well. The actual test is done in the lines that follow. @leifdenby would you agree?

d70-t commented 1 year ago

I gave it a try and it seems like the test are still doing something (e.g. fetching some data from the sources), but don't use discover() anymore.

It's a pity to get rid of it (I liked it's simplicity), but if it doesn't work, we can't use it...