search

eurec4a / eurec4a-intake

Intake catalogue for EUREC4A field campaign datasets
17 stars 19 forks source link

remove item.discover() in tests #114

Closed d70-t closed 1 year ago

d70-t commented 1 year ago

discover is seemingly not implemented for all data sources, thus this test can fail for the wrong reasons. Until discover is implemented for all sources (if that happens at all) we'll have to specialize (meta-) data loading in tests to each driver.

fixes #102

leifdenby commented 1 year ago

sorry for being late to the party here :) I think I would have rather than remove item.discover() for all sources then allow an exception to be raised for the data sources where we allow them not be raised. I assume it depends on the "plugin" type being used?

d70-t commented 1 year ago

I didn't understand what .discover() does in this case, but is not covered by .to_dask() or .get()? As far as I understood, discover would internally call e.g. to_dask or get and extract some information, but probably we are fine if any call touching the data succeeds... And we already raise if the latter don't work. @leifdenby could you tell me why we would need it?