search

eurec4a / flight-phase-separation

Collection of manually edited flight segments for all platforms participating in EUREC4A.
1 stars 6 forks source link

HALO flight phase file names don't mention version number #23

Closed Geet-George closed 3 years ago

Geet-George commented 3 years ago

To keep with EUREC4A's convention, we should add version numbers to the file names?

d70-t commented 3 years ago

We've had this discussion on mattermost. The conclusion has been that the only place where a version number is to be defined is in a tag of a specific git commit of this repository, but not in the files inside of this repository. The reason behind this is that we do not ever want to have two different files with the same version number.

We once had version numbers on files in this repository, but e.g. 5c3d0a92 changed the file while keeping the version number constant. What people should do if they want to refer to a "relased" version is to go to the releases and take the compiled release from there. We could argue that the compiled release file should have a more descriptive name an possibly also contain the version number etc.. in its file name. For that to work, we'll have to update the release workflow and need to ensure that get_flight_segments will be able to properly resolve that file name.

Geet-George commented 3 years ago

Agreed, sorry for restarting a resolved issue.