search

eurec4a / flight-phase-separation

Collection of manually edited flight segments for all platforms participating in EUREC4A.
1 stars 6 forks source link

change in QC flags based on JOANNE v0.11.x #24

Closed Geet-George closed 3 years ago

Geet-George commented 3 years ago

@d70-t this time it seems to be a different error.. One I don't seem to understand. 

could not find expected ':'
  in "<unicode string>", line 62, column 10:
        descr

Any idea what this means? And how I could solve this?

d70-t commented 3 years ago

That looks awfully identical to an error Bjorn was facing. That time my conclusion has been that for some reason, the intake catalog file has not been transferred completely to his computer. I'll have to look more into it what the exact reason might be. I still think it is something related to the http transfer, but it might still be anywhere in

Geet-George commented 3 years ago

Okay, that doesn't sound like very happy work. But this PR has far fewer changes than the previous one. Would it be possible to give it a quick glimpse and see if the concept of (and resulting changes from) this PR is okay?

d70-t commented 3 years ago

The error in your checks should be addressed in #25. Once that is merged, you can update your branch and the tests should run again.

d70-t commented 3 years ago

I think my last request for this PR (after the SAM thing) is to do an interactive rebase to consolidate the various changes into sensible commits. In particular, I would like to see one commit which takes care of these things:

and contains your description of these changes within the commit message. My reason behind this request is that I want to avoid a future situation in which we are puzzled why the sondes have changed / disappeared. Much like it is now with the change in time.

Actually probably the whole thing should be squashed into one commit including a proper commit message, as also the changes in the sondes.yaml and the changes to the irregularities are connected and somehow form one atomic change. At least I have a hard time identifying some single parts of this PR which could sensibly be applied on their own.

Geet-George commented 3 years ago

Okay. Thanks for these suggestions... I will look into the interactive rebase, and make the changes you suggest. Might take some time for me to really get it though. 😅

Geet-George commented 3 years ago

There seems to be an HTTPError: 503 Service Unavailable. Is this because the AERIS server is down?