Closed fjansson closed 1 year ago
With https://github.com/eurec4a/eurec4a-intake/pull/99 merged, this notebook works as well. I just re-run your PR in my own fork successfully: https://github.com/observingClouds/how_to_eurec4a/actions/runs/2757007834
I edited the header to mark the things that still need to be addressed before we can merge this.
@observingClouds @fjansson I've had an initial go at this, see https://github.com/martinjanssens/how_to_eurec4a/tree/botany. It could perhaps use a little more background information, we should eventually include our data set paper and the appropriate reference and we might consider waiting to merge this until after we've merged https://github.com/eurec4a/eurec4a-intake/pull/128, as I'm still referring to Hauke's private branch of eurec4a-intake
to get the most up-to-date catalog entries here. I.e. this:
from intake import open_catalog
url = "https://raw.githubusercontent.com/observingClouds/eurec4a-intake/botany/catalog.yml"
cat = open_catalog(url)
Should eventually just be this:
import eurec4a
cat = eurec4a.get_intake_catalog()
@martinjanssens thanks for taking this further! I just compiled the book locally. It looks good so far. Could you please add your branch to this branch (fjansson/how_to_eurec4a) or merge this one into yours and create a new PR so that we can discuss the details alongside the code?
Agreed, done!
@observingClouds thanks for looking at this so quickly! I've tried to address all your comments (all of which I agree with!) in 87304fc. In particular I've added an example of how to plot something like cloud fraction profiles as a function of a varied parameter, here surface wind. Let me know what you think (@fjansson you too of course!).
@martinjanssens we are getting closer to the finish line! Could you please update this PR now that the intake catalog contains the botany dataset?
Thanks a lot to you, Hauke!
Draft pull request for the botany dataset.