Improvement/intrinsics - Githubissues

adrianherrera commented 3 years ago

Support for intrinsics that commonly popped up in code that I attempted to instrument :)

Thoughts/comments welcome!

sebastianpoeplau commented 1 year ago

This is really nice @adrianherrera! I'm going to rebase the changes on the latest version of the code and try to merge them :blush:

sebastianpoeplau commented 1 year ago

Here's a summary of my changes, apart from resolving conflicts with new code:

Drop the commit that officially enables LLVM 12 because we've done it on master already.
From the commit introducing arithmetic with overflow detection, drop the parts that change how we represent Booleans in structures. We need the expressions to reflect the memory layout of the structs (see the comment on the struct case in Symbolizer::createValueExpression). However, I've added a commit that performs the necessary conversion in extractvalue/insertvalue (where floats were already handled similarly).
Minor style changes for consistency.

adrianherrera commented 1 year ago

Great, thanks @sebastianpoeplau for the rebasing! Definitely would have been happy to do this, so appreciate the extra efforts

sebastianpoeplau commented 1 year ago

Thank you for the high-quality contribution! :wink:

eurecom-s3 / symcc