build proto files without git submodule

eureka-network / rs-eureka

Eureka sink

0 stars 0 forks source link

build proto files without git submodule #61

Closed benjaminbollen closed 1 year ago

benjaminbollen commented 1 year ago

resolves #28

@vadim-frolov I started with an experiment to download the protofiles from raw github content, with the aim to remove git submodule from cargo build step (ideally this would be resolved over a CID :) )

could you have a look if you like the idea?

open todos:

[ ] actually prost build the proto to .rs
[ ] update the imports in code
[ ] should this be build.rs import a lib, because the imports need to be build multiple times?

vadim-frolov commented 1 year ago

Good to get rid of submodules. I would try to minimize the refactoring and continue using autogenerated tonic code if you don't mind. I came across git-download crate when searching for alternatives. What do you think #64 ?

benjaminbollen commented 1 year ago

superceded by #64