search

eureka2 / ab-datepicker

An accessible and bootstrap compatible datepicker
MIT License
63 stars 55 forks source link

Selectable Grid focus indication #25

Closed alours closed 6 years ago

alours commented 7 years ago

Greetings. Thank you for working on this project. I think I found an issue with your grid focus indication because in the current version, when focus shifts to the grid, any indication pretty much disappears until you move to another day using the arrow keys.

Using the blue theme, I found the issue (as I see it in the datepicker.css file). In fact, it seems to be this way in every theme, but each line that should provide focus has...

div.datepicker2-calendar.blue table.datepicker2-grid td.selectable:hover, div.datepicker2-calendar.blue table.datepicker2-grid td.selectable.focus { background-color: #0B6BA8; color: #FFF; border-color: #3484B7; }

On the second entry, it ends with "td.selectable.focus" and I think it should end with "td.selectable:focus". Anyway, that fixed it for me and made the focus pop when switching into the grid itself. Again, it looks like it is this way throughout the css file, so they probably all need fixing.

eureka2 commented 6 years ago

This is not an error because "focus" is a css class that is added / removed dynamically in Javascript by this component.

I can not reproduce what you indicate.

Is it the same here: http://eureka2.github.io/ab-datepicker/

eureka2 commented 6 years ago

No answer, I close this issue