search

eurekaclinical / aiw-i2b2-etl

Protempa i2b2 tools
Apache License 2.0
0 stars 5 forks source link

Implement logic in the Postgresql stored procedures to delete records #7

Closed arpost closed 8 years ago

arpost commented 8 years ago

Depends on #1.

arpost commented 8 years ago

In reviewing the stored procedure updates, I noticed a pattern that there's an UPDATE statement with a WHERE clause to skip updating records marked for deletion followed by a DELETE statement that deletes records marked for deletion. If you reversed the order of those statements, you might be able to remove that part of the WHERE clause in the UPDATE statement.

candyam5522 commented 8 years ago

Okay, thanks for the suggestion!

On Fri, Feb 26, 2016 at 8:42 AM, Andrew Post notifications@github.com wrote:

In reviewing the stored procedure updates, I noticed a pattern that there's an UPDATE statement with a WHERE clause to skip updating records marked for deletion followed by a DELETE statement that deletes records marked for deletion. If you reversed the order of those statements, you might be able to remove that part of the WHERE clause in the UPDATE statement.

— Reply to this email directly or view it on GitHub https://github.com/eurekaclinical/aiw-i2b2-etl/issues/7#issuecomment-189281958 .