euro-hpc-pl / setuptools_cuda

Setuptools plugin for compiling CUDA-enable extension modules
2 stars 0 forks source link

Hello, same idea bad timing #2

Open RafaelJVicente opened 1 year ago

RafaelJVicente commented 1 year ago

Hello, I was working in a library (surprisingly with exactly the same name as yours) for the past few months that also includes multiplatform support (tested in Windows and Ubuntu 18/20) that also works from for Python 3.6+. I was putting a lot of effort in the implementation because is the first package I have done for Pypi and I was tunning the configuration for the project. My implementation includes advanced findCuda to avoid setting the CUDA_HOME variable and Ninja support, both features for win/linux. Unfortunately when I want to upload it I notice you just have taken the name a week ago. I will go for a similar name in Pypi for my project and I wonder if at the moment i upload it you can check if my entry point works with your CUDA projects because it would be good to know if my approach works with your POSIX applications. Currently I have the project at private GitLab but I can move it to GitHub and include you as contributor to collaborate. Please let me know your thoughts, thank you for your time.

dexter2206 commented 1 year ago

Hey, thanks for reaching out. I think that the best thing to do would be to coordinate our efforts and not to duplicate packages on PyPI. Let me see your project (preferably, move it to GitHub and give me right as a collaborator), I'll take a look and then we'll discuss how to proceed with this.

RafaelJVicente commented 1 year ago

Hello, sorry for the late response, I've already upload the extension: https://pypi.org/project/setuptools-cpp-cuda/

dexter2206 commented 1 year ago

I take it that you are not interested in cooperation and this issue can be closed, right?

RafaelJVicente commented 1 year ago

Sorry I don't understand, I've got a pretty busy week and I need the library working for one project I'm doing, and since I use to work in gitlab I have it there. You told me that you want to see my project and I'm showing it to you, but as I explained I think both are for different target people, but of course I can cooperate with you.

dexter2206 commented 1 year ago

Alright then, I probably wasn't clear enough. What I thought was that we could have one library on PyPI instead of duplicating the libraries (possibly under the setuptools_cuda name, because it's shorter). But if, as you said, our libraries target different people then you are probably right about having separate packages.

Btw. I looked at your library and it looks really nice!

RafaelJVicente commented 1 year ago

Well, yeah, my point is that I don’t want to be disrespectful coming here and saying "let’s change all of your approximation for mine one", especially since you have the name. One point is that your entry point is totally different from mine: You created a new variable for setup.py and I’m reusing the typical one and the python version 3.9+ (I think you can go for a 3.7 without changing anything) for me is a big problem since I have deployments that use 3.6. The name is definitely a problem since a lot of people will come asking for a extended version. Maybe the best solution would be to unify them in a GitHub project owned by both of us that is a fork of my GitLab and use only the name "setuptools-cuda", but, if you don't mind, I would like to keep the authorship of the module and the control over it in GitHub/ and Pypi as first author and you as second. Another idea could be that I own the GitHub organization, and you own Pypi (I add you in GitHub and you add me in Pypi for the name). If you are not interested in these ideas, I totally understand it. As always please let me know your thoughts, ty in advance.

RafaelJVicente commented 1 year ago

One thing I dont controll at all is auto testing and building in GitHub. I saw that you do the thing with yours, just in case you want to help to my approximation.