search

euroargodev / ArgoNetCDF

Argo NetCDF format and content
Creative Commons Zero v1.0 Universal
6 stars 2 forks source link

Data type of HISTORY_PREVIOUS_VALUE #11

Closed MarkIggy closed 1 year ago

MarkIggy commented 2 years ago

In the FileChecker, HISTORY_PREVIOUS_VALUE is type float in all of the file types except Bio-profile. In Bio-profile, either float or double is accepted. I don't remember the history of this.

My question: What should we enforce for traj-v3.2?

(I am currently only allowing float but Jean-Philippe uses double in some or all of his v3.2 files.)

apswong commented 1 year ago

Hi @MarkIggy. I believe "double" is needed in bgc files because some bgc parameters need 64bit storage. e.g. radiometry counts. The data type of each parameter is noted in the parameters xlsx, which @catsch maintains. The GDAC file checker should be synched with the parameters xlsx.

Since traj-v3.2 is designed to hold both core and bgc parameters, HISTORY_PREVIOUS_VAUE in traj-v3.2 should accommodate both "float" and "double" values. Most traj files will only require "float", but some traj files with bgc data will require "double".

MarkIggy commented 1 year ago

This issue was implemented in v2.8.00. HISTORY_PREVIOUS_VALUE may be either float or double in traj-v3.2