search

euroargodev / ArgoNetCDF

Argo NetCDF format and content
Creative Commons Zero v1.0 Universal
6 stars 2 forks source link

Trajectory AXES_ERROR_ELLIPSE_MAJOR #3

Closed tcarval closed 2 years ago

tcarval commented 2 years ago

Replace AXES_ERROR_ELLIPSE_MAJOR.long_name = “Major axis of error ellipse from positioning system”; by AXES_ERROR_ELLIPSE_MAJOR.long_name = “Semi-major axis of error ellipse from positioning system”; (and AXES_ERROR_ELLIPSE_MINOR.long_name = “Minor axis of error ellipse from positioning system”; by AXES_ERROR_ELLIPSE_MINOR.long_name = “Semi-minor axis of error ellipse from positioning system”;)

Jean-philippe is wondering if it is suitable to store ellipses major axis of Argos locations (and CEP diameter of Iridium locations) while:

apswong commented 2 years ago

I would support this proposal to change the long_name from major/minor to semi-major/semi-minor. That will clarify that these two variables should be filled with radii and not diameters of the ellipse. However, I would suggest changing this in V3.2 traj only, and not in V3.1 traj. That will spare the DACs and the GDAC file checker from having to upgrade the old V3.1 traj files.

ClaudiaAOML commented 2 years ago

I agree with Annie. Doing this for traj 3.2 only will be better for DACs and GDACs. Hopefully 3.1 traj files will eventually disappear.

mscanderbeg commented 2 years ago

I also agree with Annie and Claudia.

cgourcuf commented 2 years ago

I agree too (although I am not familiar with traj files... Something I need to work on!)

MarkIggy commented 2 years ago

This change can be accomodated in traj 3.1 too. The FileChecker will allow for "alternate" settings and could even "warn" on the old settings.

MarkIggy commented 2 years ago

I am working on the traj-v3.2 in the FileChecker. Is the change to "Semi-..." approved? Should the traj-v3.2 enforce the "Semi-major .../Semi-minor ..." wording of the long_name?

If yes, the User Manual needs to updated to reflect the new requirement.

apswong commented 2 years ago

I consider this change to "Semi-" in the long_name an agreed item. Please include this in the traj-v3.2 checker. Thanks @MarkIggy.

Hi @tcarval. There are several changes that need to be recorded in the Argo Users Manual. Could we please aim to release an updated Users Manual soon? Thank you!

tcarval commented 2 years ago

The next version of the user's manual will go for "Semi-" ellipses, see https://github.com/euroargodev/ArgoNetCDF/issues/9