search

euroargodev / User-Acceptance-Test-Python-version-of-the-OWC-tool

BODC Argo team with consultation with other Argo partners took initiative to convert the OWC software from Matlab to Python. This initiative has been undertaken based on the output from the international survey about the methods and tools used in DMQC core data. The following repository is dedicated for User Acceptance Testing.
1 stars 0 forks source link

Legend range in T/S plot of uncalibrated and calibrated float data #28

Closed kamwal closed 4 years ago

kamwal commented 4 years ago

In Python version of T/S plot of uncalibrated and calibrated float data, the legend is displying only elements for six profiles, from the range between 0 and 25 profiles. The legend should represent the profiles from the entire length of the float life, e.g. every 5th profile.

After consultation with Ed, the code should display in legend max 30 elements. At the moment, code is displying elements taken only from the first 30 profiles, which is a bug.

Python plot at the left and Matlab plot at the right

image

Reference data: CTD_for_DMQC_2019V01 WMO boxes: wmo_boxes_ctd.mat Cal series: ` breaks = [] max_breaks = 4 # 0 for linear trend, -1 for offset calseries = np.ones((1, no_profiles)).flatten()

example for splitting time series at profile 33

    # calseries = np.concatenate((np.ones((1, 33)), 2 * np.ones(1,no_profiles - 33)))
    calib_profile_no = profile_no
    use_percent_gt = 0.5
    use_theta_lt =0
    use_theta_gt =0
    use_pres_lt =0
    use_pres_gt = 0`
kamwal commented 4 years ago

The minor note is that both uncalibrated and calibrated plots from Python code do not have float number in the plot title.

edsmall-bodc commented 4 years ago

This will be fixed in THIS PR

matdon17 commented 4 years ago

Can this issue be closed now?