search

euroargodev / argodmqc_owc

Argo float salinity calibration software
Apache License 2.0
10 stars 3 forks source link

Kamwal/data mapped diff #61

Closed kamwal closed 3 years ago

kamwal commented 3 years ago

Task or Issue

Issue 1 - Wrong sorting of selected_hist parameter in mapping.mat file

Issue 2- Relatively large differences between Matlab and Python output in la_mapped_sal and la_mapped_errors.

Symptom

Issue 1 - The longitude and latitude selected for each float profile was in random order compared with its Maltab version.

Issue 2- The differences between matlab and python version in la_mapped_sal and la_mapped_errors were in order on 10x-2 for example float WMO 3901960.

Problem

Issue 1 - This parameter is saved to mapped.mat file. This parameter is used in calc_piecewisefit function. However, this issue should not affect the calculations. The fix was undertaken to represent the same output as in Matlab version.

Issue 2- the problem was wrong size of variable "outliner", instead size 2x1 it has size 2x2. In result, too much data and wrongly selected data were excludes from historical data what lead to increase an error in further statistical calculations.

Solution

Issue 1 - The "argsort" function was replaced by the built in python "sorted" function.

Issue 2- The size of outliner has been corrected to 2x1.