euroargodev / argodmqc_owc

Argo float salinity calibration software
Apache License 2.0
10 stars 3 forks source link

Library to read Matlab files #74

Open gmaze opened 2 years ago

gmaze commented 2 years ago

I see that pyowc is using 2 libraries to read Matlab mat files:

The former is used only once, the latter basically everywhere else.

I see from #52 that pymatreader was added to fix #30 , so in fact we can't get rid of this dependency

So why using 2 dependencies for the same task ?

Should pyowc use only 1 reader ? pymatreader only

ps: This is not considering the fact that all external data should be accessible in other formats than Matlab (eg: #53)

kamwal commented 2 years ago

the pymatreader has been used to be able to read some older versions of the Matlab files. I think that yes the pymatreader might be used in the code instead of scipy.io