search

euroargodev / argodmqc_owc

Argo float salinity calibration software
Apache License 2.0
10 stars 3 forks source link

Email in setup #82

Open gmaze opened 1 year ago

gmaze commented 1 year ago

closes #80

gmaze commented 1 year ago

... tests are failing for another reason than this PR change ...

kamwal commented 1 year ago

that's failing test sounds like big problem I might look at this just after the New Year...

gmaze commented 1 year ago

that's failing test sounds like big problem

I don't think so, it's probably related to some discrepancies between the updated mat files and the hard coded values in tests.

Which, by the way, takes me to a point I wanted to raise, probably in a new issue, about separating data from test data and by using these hard coded values; this is problematic since it could be broken easily. To be continued elsewhere later !

kamwal commented 1 year ago

Oh I see now. That's a good call!